-
Notifications
You must be signed in to change notification settings - Fork 1
KEH-1227: Rewrite Docs #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦙 MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| bash-exec | 6 | 4 | 0 | 0.04s | ||
| ✅ BASH | shellcheck | 6 | 0 | 0 | 0.13s | |
| ✅ BASH | shfmt | 6 | 0 | 0 | 0.01s | |
| ✅ CSHARP | csharpier | 1 | 0 | 0 | 0.39s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.09s | |
| ✅ JSON | jsonlint | 2 | 0 | 0 | 0.21s | |
| ✅ JSON | prettier | 2 | 0 | 0 | 0.62s | |
| ✅ JSON | v8r | 2 | 0 | 0 | 3.06s | |
| ✅ MARKDOWN | markdownlint | 7 | 0 | 0 | 0.92s | |
| ✅ MARKDOWN | markdown-table-formatter | 7 | 0 | 0 | 0.35s | |
| ✅ REPOSITORY | checkov | yes | no | no | 27.86s | |
| ✅ REPOSITORY | dustilock | yes | no | no | 0.01s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 7.65s | |
| ✅ REPOSITORY | grype | yes | no | no | 53.71s | |
| ✅ REPOSITORY | kics | yes | no | no | 46.98s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 1.09s | |
| ✅ REPOSITORY | syft | yes | no | no | 4.45s | |
| ✅ REPOSITORY | trivy | yes | no | no | 14.67s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.51s | |
| ✅ TERRAFORM | terraform-fmt | 6 | 0 | 0 | 0.49s | |
| ✅ YAML | prettier | 8 | 0 | 0 | 1.03s | |
| ✅ YAML | v8r | 8 | 0 | 0 | 6.93s | |
| ✅ YAML | yamllint | 8 | 0 | 0 | 0.72s |
See detailed report in MegaLinter reports
You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.
MegaLinter is graciously provided by OX Security
- Update list of Copilot data types fetched - Move environment variables to top-level setup and remove duplication
- Update list of Copilot data types fetched - Fix architecture diagram link - Change Copilot day count following API update
- Remove old Streamlit paragraph
- Add section for Copilot teams data
|
Grype issue has fixed itself 🔥 |
TotalDwarf03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| #### Regular User | ||
|
|
||
| A user within ONSDigital. Upon authentication, the app identifies the teams they belong to and populates the selection box accordingly. If the user is part of a qualifying team, they can view the data. Users not associated with any team cannot select teams. | ||
| A user within ONSDigital. Upon authentication, the app identifies the teams they belong to and populates the UI selection accordingly. If the user is part of a qualifying team, they can view the data. Users not associated with any team cannot select teams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rewrite the first sentence to maybe, For a user within ONSDigital, upon ...
| #### Admin User | ||
|
|
||
| An enhanced regular user with the ability to search for any team. This user belongs to a specific whitelisted team, enabling them to view metrics for any team that meets the Copilot usage data requirements. | ||
| An enhanced regular user with the ability to view any team. This user belongs to a specific whitelisted team, enabling them to view metrics for any team that meets the Copilot usage data requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the other comment, the first sentence needs to be restructured.
What type of PR is this? (check all applicable)
What
Documentation refresh following Copilot lambda updates.
Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
KEH-1227
How to review
Read through README.md and markdown files within
docs.